Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connection Screens Revamp Follow-up #780

Merged
merged 22 commits into from
Jan 26, 2024
Merged

Connection Screens Revamp Follow-up #780

merged 22 commits into from
Jan 26, 2024

Conversation

m-aboelenein
Copy link
Member

🔘 PR Type

What kind of change does this PR introduce?

  • Bugfix

📜 Background

Connection Screens Recvam Follow-up

Issue Link: #[issue_number]
Context Link (if applicable):

🔄 Changes

  • display account name according to max-char limits

Impact:

  • Explain the broader impact of these changes.
  • How it improves performance, fixes bugs, adds functionality, etc.

🖼 Screenshot / 📹 Video

Screen.Recording.2024-01-26.at.12.46.20.PM.mov

✅ Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

m-aboelenein and others added 21 commits December 18, 2023 11:21
@m-aboelenein
Merge branch 'develop' into mahmoud/eng-3370-improve-get-address-screen
2e4f6ab
@m-aboelenein
init getAddress screen revamp
ac2429a
@m-aboelenein
Merge branch 'develop' into mahmoud/eng-3370-improve-get-address-screen
83ad1c5
@m-aboelenein
Merge branch 'develop' into mahmoud/eng-3370-improve-get-address-screen
c1f2fd4
@m-aboelenein
update ui
4cc9a5a
@m-aboelenein
update btc address select request
3d2ea7d
@m-aboelenein
Merge branch 'develop' into mahmoud/eng-3370-improve-get-address-screen
3954e2b
@m-aboelenein
Merge branch 'develop' into mahmoud/eng-3370-improve-get-address-screen
53b7f28
@m-aboelenein
update stx screen and add btcAddress to stacks connect response
e4b422c
@m-aboelenein
Merge remote-tracking branch 'origin/develop' into mahmoud/eng-3370-i…
8fb1916 
…mprove-get-address-screen
@m-aboelenein
ui fixes
7ceee45
@m-aboelenein
minor fixes
f2368a3
@m-aboelenein
Merge remote-tracking branch 'origin/develop' into mahmoud/eng-3370-i…
87bdd48 
…mprove-get-address-screen
@m-aboelenein
disable account actions on connection requests
c173dae
@m-aboelenein
added icon borderRadius
067bb8b
@m-aboelenein
remove debug log
c0cfa1d
@m-aboelenein
Merge remote-tracking branch 'origin/develop' into mahmoud/eng-3370-i…
2275097 
…mprove-get-address-screen
@victorkirov @m-aboelenein
Fix typing between sats connect and extension for providers (#768)
89a240b 
* Fix typing between sats connect and extension for providers

* update sats-connect version

---------

Co-authored-by: Mahmoud Aboelenein <[email protected]>
@m-aboelenein
Merge branch 'develop' into mahmoud/eng-3370-improve-get-address-screen
f4c2a2b
@m-aboelenein
resolve ui issues
ce85735
@m-aboelenein
Merge remote-tracking branch 'origin/develop' into mahmoud/eng-3370-i…
8a2cc53 
…mprove-get-address-screen
@github-actions GitHub Actions
Copy link

Test with build here: https://github.com/secretkeylabs/xverse-web-extension/actions/runs/7667116053

@teebszet teebszet changed the base branch from develop to release/v0.29.0 January 26, 2024 11:58
@m-aboelenein m-aboelenein merged commit 7ae43a5 into release/v0.29.0 Jan 26, 2024
@m-aboelenein m-aboelenein deleted the mahmoud/eng-3370-improve-get-address-screen branch January 26, 2024 16:28
@github-actions github-actions bot mentioned this pull request Jan 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DuskaT021 DuskaT021 DuskaT021 approved these changes

@teebszet teebszet Awaiting requested review from teebszet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m-aboelenein @DuskaT021 @victorkirov